Differential D12217

Give clearer names
ClosedPublic
Actions

Authored by nicolasfella on Apr 14 2018, 11:57 PM.

Details

Reviewers
apol
Group Reviewers
KDE Connect
Commits
R225:d83091faf887: Give clearer names

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Apr 14 2018, 11:57 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptApr 14 2018, 11:57 PM
nicolasfella requested review of this revision.Apr 14 2018, 11:57 PM
nicolasfella updated this revision to Diff 32159.Apr 15 2018, 12:00 AM

Propper diff

apol added a subscriber: apol.Apr 15 2018, 12:01 AM
apol added inline comments.
res/layout/activity_list.xml
3

If it's camelCasing, shouldn't it be devicesList?

nicolasfella added inline comments.Apr 15 2018, 12:08 AM
res/layout/activity_list.xml
3

We normally use underscores in layout files, camelCase was an exception

apol accepted this revision.Jul 26 2018, 5:49 PM
This revision is now accepted and ready to land.Jul 26 2018, 5:49 PM
Restricted Application added a subscriber: kdeconnect. · View Herald TranscriptJul 26 2018, 5:49 PM
Closed by commit R225:d83091faf887: Give clearer names (authored by nicolasfella). · Explain WhyJul 27 2018, 5:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38544

View Options

res/layout/activity_list.xml

Loading...
View Options

res/layout/fragment_pair.xml

Loading...
View Options

src/org/kde/kdeconnect/Plugins/SharePlugin/ShareActivity.java

Loading...
View Options

src/org/kde/kdeconnect/UserInterface/PairingFragment.java

Loading...