Fix unused param warnings
ClosedPublic

Authored by zzag on Apr 14 2018, 7:56 PM.

Details

Summary

Compiler: GCC 7.3.1
Distro: Arch Linux

Compiler warnings:

/home/vlad/KDE/src/kde/workspace/kwin/effects/blur/blur.cpp: In member function ‘void KWin::BlurEffect::upscaleRenderToScreen(KWin::GLVertexBuffer*, int, int, QMatrix4x4, QRect, QPoint)’:
/home/vlad/KDE/src/kde/workspace/kwin/effects/blur/blur.cpp:677:129: warning: unused parameter ‘windowShape’ [-Wunused-parameter]
 void BlurEffect::upscaleRenderToScreen(GLVertexBuffer *vbo, int vboStart, int blurRectCount, QMatrix4x4 screenProjection, QRect windowShape, QPoint windowPosition)
                                                                                                                                 ^~~~~~~~~~~
/home/vlad/KDE/src/kde/workspace/kwin/main_wayland.cpp: In function ‘void KWin::{anonymous}::gainRealTime(KWin::RealTimeFlags)’:
/home/vlad/KDE/src/kde/workspace/kwin/main_wayland.cpp:95:56: warning: unused parameter ‘flags’ [-Wunused-parameter]
 void gainRealTime(RealTimeFlags flags = RealTimeFlags::DontReset)

Diff Detail

Repository
R108 KWin
Branch
fix-warnings
Lint
No Linters Available
Unit
No Unit Test Coverage
zzag created this revision.Apr 14 2018, 7:56 PM
Restricted Application added a project: KWin. · View Herald TranscriptApr 14 2018, 7:56 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Apr 14 2018, 7:56 PM
anemeth added inline comments.
effects/blur/blur.cpp
679

This is a lazy way to fix it :)
This parameter was used in one of the previous iterations but not anymore, and I guess I forgot to remove it.
Could you pls modify the function to remove the windowShape parameter entirely?

zzag updated this revision to Diff 32208.Apr 15 2018, 6:53 PM

Delete unused windowShape param.

zzag marked an inline comment as done.Apr 15 2018, 6:55 PM
zzag added inline comments.
effects/blur/blur.cpp
679

Sure!

davidedmundson accepted this revision.Apr 19 2018, 9:44 PM
This revision is now accepted and ready to land.Apr 19 2018, 9:44 PM
This revision was automatically updated to reflect the committed changes.
zzag marked an inline comment as done.