Add support for touch scrolling
AbandonedPublic

Authored by abalaji on Apr 14 2018, 6:14 PM.

Details

Reviewers
None
Summary

Full touch api integration, rip drag events

Simplify conditional statement

Diff Detail

Repository
R318 Dolphin
Branch
touchscroll2
Lint
No Linters Available
Unit
No Unit Test Coverage
abalaji created this revision.Apr 14 2018, 6:14 PM
Restricted Application added a subscriber: Dolphin. · View Herald TranscriptApr 14 2018, 6:14 PM
abalaji requested review of this revision.Apr 14 2018, 6:14 PM
abalaji abandoned this revision.Apr 14 2018, 6:16 PM
markg added a subscriber: markg.Apr 16 2018, 10:08 AM

Hi,

I have a small request before i review and test it.
The code has some commented code in it, a redundant QTimer include (in the header where it also forward declares it) and a commented todo. I'm guessing you still need to do some cleanup?

Also, the summary is a bit misleading. You say "rip drag events" which lead me to think that drag/drop is completely removed. That doesn't seem to be the case when looking at the code as you haven't deleted those event handlers (thankfully, drag/drop needs to stay obviously).
Lastly, how do i test touch events on a non-touch monitor? Is there some kind of touch emulation for the desktop?

Which change is the leading one now btw?
This or D12162?

Sorry @markg, I created this revision by accident while setting up arc, D12162 is the leading one

markg added a comment.Apr 16 2018, 6:43 PM

Sorry @markg, I created this revision by accident while setting up arc, D12162 is the leading one

Please close this one then :)

I "abandonded" it, does that not do that?

And @markg I found this tool that lets you simulate a touchscreen: https://github.com/vi/virtual_touchscreen

markg added a comment.Apr 16 2018, 7:18 PM

I "abandonded" it, does that not do that?

Hmm, that might. That's darn tricky to spot if you're not looking for it ;)
And thank you for the virtual touchscreen link, will have a look at that.