autocompletion keyword
ClosedPublic

Authored by grebois on Mar 25 2016, 2:57 PM.

Details

Reviewers
mlaurent
bensi
Summary

when a user write the first letter then the keyword list beginning with this letter appear.
currently, the keyword list is temporary, later we will complete the list with real keywords.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
grebois updated this revision to Diff 2952.Mar 25 2016, 2:57 PM
grebois retitled this revision from to autocompletion keyword.
grebois updated this object.
grebois edited the test plan for this revision. (Show Details)
grebois added reviewers: mlaurent, bensi.
grebois added a project: KDE PIM: KMail.
mlaurent added inline comments.Mar 26 2016, 11:33 AM
messagelist/src/core/widgets/quicksearchline.cpp
101

You replace existing completer with your list. => History will be lost.

messagelist/src/core/widgets/quicksearchline.h
80

QStringList no ?

ok for QStringList
but for the first observation, when i test, the history is not lost. I didn't see this strange behavior :
when i write "f", the keyword "from" appear and if i ignore it and i write for example "for" , the keyword "from" disappear.
now if i clear the text and i write "f", the history "for" appear (not "from") but if i click outside this list or if i add "r" ("fr"), the history disappear and the keyword "from" appear.

the history overrides the keyword list.
what can i do ? i let this behavior, i merge the 2 lists, i delete the history list ?
currently, the user story is for "autocompletion keyword" not storing history.

grebois updated this revision to Diff 2973.Mar 27 2016, 11:52 AM

add keyword list

mlaurent edited edge metadata.Apr 9 2016, 5:51 AM

We still need to keep history.

> for sure we need to merge 2 lists.

grebois updated this revision to Diff 3304.Apr 12 2016, 9:02 PM
grebois edited edge metadata.

merge the 2 lists : keywordList + historyList

mlaurent added inline comments.Apr 19 2016, 12:00 PM
messagelist/src/core/widgets/quicksearchline.cpp
85–87

Q_FOREACH(const QString &str, listKeyword) {

...

}

grebois updated this revision to Diff 3425.Apr 19 2016, 2:09 PM

Q_FOREACH used

mlaurent accepted this revision.Apr 20 2016, 5:04 AM
mlaurent edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2016, 5:04 AM
mlaurent closed this revision.Nov 4 2017, 8:39 AM