Make some frameworks optional so okular can be built on Android
ClosedPublic

Authored by apol on Apr 13 2018, 4:44 PM.

Details

Summary

Disables KWallet integration if there's no KWallet, KJS if there's no
KJS and KDocTools.
Here's a list of frameworks that don't work on Android:
https://cgit.kde.org/sysadmin/ci-tooling.git/tree/local-metadata/project-ignore-rules.yaml

Test Plan

Still works locally, ran Okular and Okular Mobile on Android.

Diff Detail

Repository
R223 Okular
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Apr 13 2018, 4:44 PM
Restricted Application added a project: Okular. · View Herald TranscriptApr 13 2018, 4:44 PM
apol requested review of this revision.Apr 13 2018, 4:44 PM
aacid added a subscriber: aacid.Apr 13 2018, 10:50 PM

This is not ok.

This change makes it so that people will be missing functionality without anyone warning them.

If you really want to have this please make flags to explicitely make them optional and otherwise still make them required.

aacid requested changes to this revision.Apr 16 2018, 6:55 AM
This revision now requires changes to proceed.Apr 16 2018, 6:55 AM
apol updated this revision to Diff 32296.Apr 16 2018, 3:13 PM

Address Albert's concern

aacid requested changes to this revision.Apr 16 2018, 4:33 PM

HAVE_KWALLET is never defined

This revision now requires changes to proceed.Apr 16 2018, 4:33 PM
apol updated this revision to Diff 32303.Apr 16 2018, 4:39 PM

Shouldn't comment the include...

apol updated this revision to Diff 32317.Apr 16 2018, 7:01 PM

Unsure why it works on my system, adopt the same way to point to the path katepart uses

aacid accepted this revision.Apr 16 2018, 8:41 PM

I'll push it, i've fixed the removal of the #if 0 in scripter.cpp

This revision is now accepted and ready to land.Apr 16 2018, 8:41 PM
This revision was automatically updated to reflect the committed changes.