Check for valid _foregroundProcessInfo to prevent crash
ClosedPublic

Authored by ahmadsamir on Apr 13 2018, 3:31 PM.

Details

Summary

In Session::getUrl() check that _foregroundProcessInfo is valid before
tyring to access its members.

I couldn't reproduce the crash from the BR, but it is logical to call
isValid() before accessing any ProcessInfo object members.

BUG: 391447

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Apr 13 2018, 3:31 PM
Restricted Application added a project: Konsole. · View Herald TranscriptApr 13 2018, 3:31 PM
Restricted Application added a subscriber: Konsole. · View Herald Transcript
ahmadsamir requested review of this revision.Apr 13 2018, 3:31 PM
hindenburg accepted this revision.Apr 14 2018, 10:21 AM

good - we should find all the other locations and add checks

This revision is now accepted and ready to land.Apr 14 2018, 10:21 AM
This revision was automatically updated to reflect the committed changes.