After cropping a zoomed image and undoing this operation the view
offset is wrong in some cases.
This patch updates image offset and scroll position after a raster
image rect was changed.
FIXED-IN: 18.04.1
Details
Details
- Reviewers
rkflx - Group Reviewers
Gwenview - Commits
- R260:dafe25a8623a: Update view offset in higher zoom levels after image size changed
- Open image in View Mode with a zoom level to enable scroll
- Edit one time to show save bar (e.g. resize, rotate)
- Crop to a rectangle with distance from left and top edge
- Undo
- Image should display in whole window again
Diff Detail
Diff Detail
- Repository
- R260 Gwenview
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| lib/documentview/documentview.cpp | ||
|---|---|---|
| 413–415 | This is needed to update the minimum zoom level, otherwise it stays at 100% after undoing the crop operation. | |
Comment Actions
First I wondered why now the zoom slider was jumping when rotating, but then it made sense: The minimum zoom changes for non-square images upon rotating due to it corresponding to Fit.
Thanks!
This actually fixes another problem (or perhaps it's just another way of triggering): Open huge image, zoom all the way out (but do not use Fit), then Rotate two times and observe the image being offset.
Found somewhat related problems when testing your patch, though:
- Rotating a huge image first displays a stretched version in the viewport before updating to the final rotated image.
- Moving the zoom slider all the way to the left and then pressing Fit, the image still changes slightly.