[Kickoff] Support non-square icons
ClosedPublic

Authored by broulik on Thu, Apr 12, 7:22 PM.

Details

Summary

You can load custom icons through icon dialog, so support non-square icons just like Kicker does. Code mostly from Kicker.

Test Plan

  • Size is sane in both vertical and horizontal panel
  • Square icons (and the default one) are still rounded to icon size
  • Verified with kolourpaint that square icon looks identical with and without this patch (I still fear there might be a "icon washed out" or "frizzled" regression somehow caused by this on low dpi screens (but who doesn't have a 8K monitor these days)
  • Changing icon updates size at runtime
  • Resizing panel updates size immediately

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Thu, Apr 12, 7:22 PM
Restricted Application added a project: Plasma. · View Herald TranscriptThu, Apr 12, 7:22 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Thu, Apr 12, 7:22 PM
davidedmundson accepted this revision.Thu, Apr 12, 7:23 PM
This revision is now accepted and ready to land.Thu, Apr 12, 7:23 PM
Fuchs added a comment.Thu, Apr 12, 7:25 PM

happy fox now happy, says thanks :)

How could the VDG ever, ever disapprove of an image like that? :)

Fuchs accepted this revision.Thu, Apr 12, 7:36 PM
This revision was automatically updated to reflect the committed changes.