Share activity, Fix score overriding.
ClosedPublic

Authored by ganeshredcobra on Apr 12 2018, 5:50 PM.

Details

Reviewers
timotheegiet
Group Reviewers
GCompris
Maniphest Tasks
T7705: Share activity, Fix score overriding.
Summary

Share activity, Fix score overriding.

Changing the score dynamically for Vertical and Horizontal views

Screenshot Vertical layout

https://pasteboard.co/HgiRx28.png

Screenshot Horizontal layout

https://pasteboard.co/HgiRHuv.png

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
ganeshredcobra created this revision.Apr 12 2018, 5:50 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptApr 12 2018, 5:50 PM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript
ganeshredcobra requested review of this revision.Apr 12 2018, 5:50 PM

Some part of the score hides on many horizontal screen dimensions: https://pasteboard.co/HgjToTY.png

timotheegiet requested changes to this revision.Apr 13 2018, 11:20 AM
timotheegiet added a subscriber: timotheegiet.

As Aman said, there's still an issue with "widescreen" layout (horizontal window with smaller height)

This revision now requires changes to proceed.Apr 13 2018, 11:20 AM

updated the patch so that score wont get hidden for horizontal window with smaller height

timotheegiet accepted this revision.Apr 17 2018, 11:01 AM

Tested, and code looks ok. Please commit.

This revision is now accepted and ready to land.Apr 17 2018, 11:01 AM

@timotheegiet, ganesh doesn't have write access :)

timotheegiet closed this revision.Apr 17 2018, 11:09 AM

Oh right. I'll commit it, and closing the revision.