update the wallpaper dialog to the new design
ClosedPublic

Authored by mart on Apr 12 2018, 1:04 PM.

Details

Summary

update the wallpaper dialog to the same design as the new KCMS
for consistency

Test Plan

dialog loads with proper wallpaper selected, and both clicking on one
works and the attached toolbuttons work too

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Apr 12 2018, 1:04 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 12 2018, 1:04 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Apr 12 2018, 1:04 PM
abetts added a subscriber: abetts.Apr 12 2018, 2:37 PM

Looks good to me!

Now I don't see any wallpapers in the list

GridDelegate.qml:63: ReferenceError: view is not defined

I did update kdeclarative and kirigami before

mart added a comment.Apr 13 2018, 4:37 PM

Now I don't see any wallpapers in the list

GridDelegate.qml:63: ReferenceError: view is not defined

I did update kdeclarative and kirigami before

ouch right, depends from unsubmitted stuff in kdeclarative, sorry (how the whole thing lays out is still up to debate so i have thousands local branches with vertical approaches :/)

mart updated this revision to Diff 32281.Apr 16 2018, 1:27 PM
  • adapt to new design

When you can, can you share a screenshot of the progress? I am so excited to see this!

davidedmundson requested changes to this revision.Apr 16 2018, 2:30 PM
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
wallpapers/image/imagepackage/contents/ui/config.qml
286–294

You can't have both.

This revision now requires changes to proceed.Apr 16 2018, 2:30 PM
mart updated this revision to Diff 32289.Apr 16 2018, 2:51 PM
  • remove explicit width
mart marked an inline comment as done.Apr 16 2018, 2:51 PM
broulik accepted this revision.Apr 16 2018, 2:52 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 16 2018, 2:58 PM
This revision was automatically updated to reflect the committed changes.