Use consistent spacing and units for suffixes in spinboxes
ClosedPublic

Authored by kossebau on Apr 12 2018, 12:38 AM.

Details

Summary

As specified by the International System of Units (SI) there is usually a
space between the number and the unit (symbol). To still allow localisations
to apply some custom appendix of the unit, the separating space is part of the
string to translate.

For common units like seconds and minutes the SI symbols "s" & "min" are
used, while for others more explicit terms are used ("days", "strips per
comic").

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Apr 12 2018, 12:38 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 12 2018, 12:38 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kossebau requested review of this revision.Apr 12 2018, 12:38 AM

Is there any mention about unit symbols appending in the HIG? Would be interesting to know what for consistent UI is recommended e.g. for "days", where some are used to "d" as unit, while the mere mortal might be more familiar/comfortable with "days" in the UI of their computer. Possibly even the same for "secondss" vs. "s" and "minutes" vs. "min".

kossebau edited reviewers, added: Localization; removed: kde-i18n-doc.Apr 12 2018, 12:53 AM
kossebau added a project: Localization.
davidedmundson accepted this revision.Apr 12 2018, 9:15 AM
davidedmundson added a subscriber: davidedmundson.

Seems we do this in designer files for QWidget spinboxes too.

This revision is now accepted and ready to land.Apr 12 2018, 9:15 AM

@davidedmundson Thanks for review. Delaying push of this patch though for now a little, until https://marc.info/?l=kde-i18n-doc&m=152354758527289&w=2 ("RFC: Notation of numbers with (physical) units/symbols") has been discussed with a result

aacid added a subscriber: aacid.Apr 12 2018, 5:21 PM

is appendix something people would understand? because for me is "the things that kills you if you're unlucky", "the end chapter of a book".

is appendix something people would understand? because for me is "the things that kills you if you're unlucky", "the end chapter of a book".

Good question. I run chance of creating garbage english given I have no real contact to native speakers and a fantasy-driven language brain ;)

Update of patch coming with a new wording proposal.

kossebau updated this revision to Diff 32427.Apr 17 2018, 9:02 PM

try other context pattern: spacing to number + unit

@aacid Does the new context pattern "spacing to number + unit" make more sense to you (and remind you less of sad things ) )?

Would then push this otherwise now, given that the new proposed context UI marker will be only really available once 4.46 is out, so it does not bitrot or forgotten as I might have no time.

aacid added a comment.Apr 20 2018, 5:35 PM

yeah i think that's easier to understand

This revision was automatically updated to reflect the committed changes.