It is fine to neither support reading of attrs nor setting the NO_COW
flag. The latter only happens when the filesystem does not use CoW at
all.
Details
Details
- Reviewers
adridg michaelh - Group Reviewers
Baloo Frameworks - Commits
- R293:92ff146f5563: Allow disabling of CoW to fail when not supported by filesystem
make
TMPDIR=<dir on XFS> ctest
TMPDIR=<dir on BTRFS> ctest
strace -eioctl -f ctest -R transactiontest
Works on BTRFS and TMPFS, silently ignores EOPNOTSUPP on XFS (without reflink support)
Diff Detail
Diff Detail
- Repository
- R293 Baloo
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Accepted as "doesn't hurt the non-Linux crowd, since they all live in the #ifndef Q_OS_LINUX branch"
Comment Actions
Of course, but what's the logic here? Does it have to be accepted by a member of Baloo other than you? If I had known ....
Comment Actions
The original author/submitter of a diff for review isn't able to approve their own review, which is why Stefan wasn't permitted to approve this diff.
Comment Actions
Yes, thanks. That's the the part I had figured out (wouldn't make much sense otherwise). This patch already had been accepted so it surprised me that my approval was also necessary.
Comment Actions
If there are multiple reviewers then approval of all reviewers is required which is why your approval was also needed