Differential D12129

Make Qt5Network conditional on BUILD_TESTS
ClosedPublic
Actions

Authored by asturmlechner on Apr 11 2018, 10:55 PM.

Details

Reviewers
iromanov
sitter
rjvbb
Commits
R486:e854f357f403: Make Qt5Network conditional on BUILD_TESTS
Summary

I did not find it in use somewhere else.

Diff Detail

Repository
R486 QCA Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
asturmlechner requested review of this revision.Apr 11 2018, 10:55 PM
asturmlechner created this revision.
rjvbb accepted this revision.Jun 2 2018, 11:47 PM

LGTM - but is QtNetwork ever installed as a separate package rather than as a part of QtBase?

This revision is now accepted and ready to land.Jun 2 2018, 11:47 PM
asturmlechner added a comment.Jun 3 2018, 12:02 AM

With split packaging yes.

rjvbb added a comment.Jun 3 2018, 5:44 PM

You're right, didn't notice that - and couldn't imagine that anyone would bother, too. You probably end up with all QtBase sub/split packages installed pretty quickly anyway.

Closed by commit R486:e854f357f403: Make Qt5Network conditional on BUILD_TESTS (authored by asturmlechner). · Explain WhyJun 6 2018, 9:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (6 lines)

Diff 35668

View Options

CMakeLists.txt

Loading...