Only install translations if they are available
AbandonedPublic

Authored by heikobecker on Apr 11 2018, 4:03 PM.

Details

Reviewers
graesslin
ltoscano
Group Reviewers
Plasma
Summary

Otherwise an empty directory might get installed if 'po' doesn't
exist, which some packaging systems don't like.

Diff Detail

Repository
R129 Window Decoration Library
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
heikobecker created this revision.Apr 11 2018, 4:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 11 2018, 4:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
heikobecker requested review of this revision.Apr 11 2018, 4:03 PM
ltoscano requested changes to this revision.May 15 2018, 4:30 PM
ltoscano added a subscriber: ltoscano.

This change should not be needed; ki18n_install is a noop operation if the directory does not exist - did you see any issue?

This revision now requires changes to proceed.May 15 2018, 4:30 PM

This change should not be needed; ki18n_install is a noop operation if the directory does not exist - did you see any issue?

Yeah, it tries to install an empty dir: '/usr/share/locale'

I'd argue that ki18n_install should be fixed instead. It does not make sense to duplicate the if check for every call to ki18n_install.

I'd argue that ki18n_install should be fixed instead. It does not make sense to duplicate the if check for every call to ki18n_install.

Seems every other ki18n_install call in Plasma repos is behind that or a similar check. But I see your point -> https://phabricator.kde.org/D12905

heikobecker abandoned this revision.May 15 2018, 7:31 PM