Differential D12112

Fix compiler warning under Clang
ClosedPublic
Actions

Authored by kfunk on Apr 11 2018, 1:02 PM.

Details

Reviewers
apol
Commits
R244:53f44072c70a: Fix compiler warning under Clang
Summary

Issue:
In file included from .../kcoreaddons/src/lib/caching/kshareddatacache.cpp:25:
.../kcoreaddons/src/lib/caching/kshareddatacache_p.h:169:47: warning: unknown attribute 'artificial' ignored [-Wunknown-attributes]

__attribute__((always_inline, gnu_inline, artificial))
                                          ^

Diff Detail

Repository
R244 KCoreAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk created this revision.Apr 11 2018, 1:02 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 11 2018, 1:02 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
kfunk requested review of this revision.Apr 11 2018, 1:02 PM
apol requested changes to this revision.Apr 11 2018, 1:47 PM
apol added a subscriber: apol.

Otherwise looks good.

src/lib/caching/kshareddatacache_p.h
170

No need to check twice for Q_CC_GNU

This revision now requires changes to proceed.Apr 11 2018, 1:47 PM
kfunk updated this revision to Diff 31888.Apr 11 2018, 2:15 PM

Address concerns. I knew why I put this up for review. /me grabs another coffee...

apol accepted this revision.Apr 11 2018, 6:19 PM

☕

This revision is now accepted and ready to land.Apr 11 2018, 6:19 PM
Closed by commit R244:53f44072c70a: Fix compiler warning under Clang (authored by kfunk). · Explain WhyApr 11 2018, 6:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31914

View Options

src/lib/caching/kshareddatacache_p.h

Loading...