Support snap permissions in Discover
ClosedPublic

Authored by apol on Apr 11 2018, 12:43 AM.

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Apr 11 2018, 12:43 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 11 2018, 12:43 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Apr 11 2018, 12:43 AM

+1 for the feature, but could we use checkboxes instead of toggles? I'm not real thrilled with the ones in those screenshots. It's not at all clear what's on and what's off.

Also those labels are not very descriptive; are there better strings available? Looking at the screenshots, I have no idea what most of those permissions actually do. A regular user would be even more confused.

apol updated this revision to Diff 31911.Apr 11 2018, 5:52 PM

Address issues by upstreap snapdqt maintainer Robert Ancell.
Change to show a check box instead of the slider.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 11 2018, 11:26 PM
This revision was automatically updated to reflect the committed changes.