HIG entry for On-demand pattern and swipe list item
ClosedPublic

Authored by fabianr on Apr 10 2018, 2:46 PM.

Details

Summary

Added desktop behaviour to on demand pattern

Diff Detail

Repository
R985 KDE Human Interface Guidelines
Branch
swipe
Lint
No Linters Available
Unit
No Unit Test Coverage
fabianr requested review of this revision.Apr 10 2018, 2:46 PM
fabianr created this revision.
mart added inline comments.Apr 10 2018, 2:48 PM
source/patterns/command/ondemand.rst
12

maybe add a dolphin screenshot as well with the + on hover? (or folderview)

fabianr updated this revision to Diff 31867.Apr 11 2018, 10:41 AM
  • Refactored on demand pattern, moved swipe list item specific details to the components page
fabianr retitled this revision from Ported ondemand pattern to rst to HIG entry for On-demand pattern and swipe list item.Apr 11 2018, 10:45 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptApr 18 2018, 2:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added a comment.Apr 18 2018, 2:38 PM

this may be an example screenshot for kirigami

fabianr updated this revision to Diff 32867.Apr 23 2018, 7:47 AM
  • Merge branch 'master' into swipe
  • added a screenshot for a desktop swipelistitem, small formating change
  • Added png file
fabianr added inline comments.May 4 2018, 7:56 AM
source/patterns/command/ondemand.rst
12

There is a dolphin screenshot with the hover in the desktop section, (line 48+)

mart added a comment.May 4 2018, 9:02 AM

ok for the text, the screenshots would need update:
both of them at the moment are desktop, which is ok (i would add the mouse cursor)
and one mobile is needed, provided here:
Desktop, listview:


Mobile, listview:
(added a thing to indicate touch, no idea if it maskes sense)
Desktop, Grid view:

We will need to design something for mobile gridview as well i guess as it would be widely used as well i guess (eg photo gallery)
but that's for a next iteration :)

fabianr updated this revision to Diff 33609.May 4 2018, 9:12 AM
  • Updated visuals for listview and folderview
mart accepted this revision.May 4 2018, 9:29 AM
This revision is now accepted and ready to land.May 4 2018, 9:29 AM

See inline comments. Otherwise it looks good!

source/patterns/command/ondemand.rst
28

Since this is a command pattern, shouldn't this link to command patterns instead of navigation patterns?

58

I'd add a screenshot of the swipelistitem here as well

60

swip -> swipe

fabianr marked an inline comment as done.May 4 2018, 2:36 PM
fabianr added inline comments.
source/patterns/command/ondemand.rst
28

My intention was to suggest switching to a navigation pattern like "Master-Detail" or "Column-based navigation", so each item has its own content page where more actions could easily be displayed.

What kind of command pattern would you suggest could replace the 3+ actions?

fabianr updated this revision to Diff 33631.May 4 2018, 2:37 PM
  • Fixed typo
colomar added inline comments.May 4 2018, 6:21 PM
source/patterns/command/ondemand.rst
28

Ah okay, now I understand what you mean. I don't think that becomes clear through that wording, however.

In any case, it's the command pattern that is directly affected by the number of actions. It is true that the command patterns that work well for for more than three actions usually necessitate a deeper hierarchy, but that is then the next step. The first decision is which command pattern to choose, and that can be for example a context drawer or controls within content.

So I'd still suggest to change it to a link to command patterns. Once the designer has chosen a suitable command pattern, then they have to figure out which navigation pattern best suits that.

fabianr updated this revision to Diff 33745.May 7 2018, 7:34 AM
  • Changed 'How to use' for on demand pattern to incorporate phab feedback
fabianr marked an inline comment as done.May 7 2018, 8:17 AM

Currently we have a screenshot of the nouseover in Dolphin in here, but screenshots for swipeListItem only in the corresponding page. That gives preference to the Dolphin pattern because lazy people will implement what they see first. Therefore there should either be screenshots for both options here, or no screenshots at all.

More concrete suggestion: Move the Dolphin screenshot to the top, next to the mobile screenshot.

fabianr updated this revision to Diff 34271.May 16 2018, 9:08 AM
  • moved example image to the top in ondemand pattern
fabianr updated this revision to Diff 34275.May 16 2018, 9:30 AM
  • removed border around dolphin example in ondemand pattern
colomar accepted this revision.May 16 2018, 9:31 AM

Perfect!

fabianr closed this revision.May 16 2018, 9:34 AM