Differential D12082

Don't offer qml plugin as a link target
ClosedPublic
Actions

Authored by leinir on Apr 10 2018, 9:57 AM.

Tags

Subscribers

None

Details

Reviewers

Group Reviewers

Frameworks
KNewStuff

Commits

R304:469db5c6934b: Don't offer qml plugin as a link target

Summary

This removes the KNSQuick plugin as a link target for cmake. It was never intended to be one, and this was just never picked up as it didn't cause issues until attempting to build an app using it on the Windows binary factory. The patch also switches to using the KDE QML install locations, equalising it with other Frameworks.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

leinir created this revision.Apr 10 2018, 9:57 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptApr 10 2018, 9:57 AM

leinir requested review of this revision.Apr 10 2018, 9:57 AM

apol accepted this revision.Apr 10 2018, 1:47 PM

This revision is now accepted and ready to land.Apr 10 2018, 1:47 PM

Closed by commit R304:469db5c6934b: Don't offer qml plugin as a link target (authored by leinir). · Explain WhyApr 11 2018, 9:05 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (1 line)
M			KF5NewStuffQuickConfig.cmake.in (2 lines)
M			src/qtquick/CMakeLists.txt (6 lines)

Diff 31859

CMakeLists.txt

Loading...

KF5NewStuffQuickConfig.cmake.in

Loading...

src/qtquick/CMakeLists.txt

Loading...