Differential D12081

Fix warning
ClosedPublic
Actions

Authored by apol on Apr 10 2018, 9:13 AM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:18228385e172: Fix warning
Summary

.../kirigami.2/ScrollablePage.qml:160: TypeError: Cannot assign to read-only property "parent"

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Apr 10 2018, 9:13 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptApr 10 2018, 9:13 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Apr 10 2018, 9:13 AM
mart accepted this revision.Apr 10 2018, 9:24 AM
This revision is now accepted and ready to land.Apr 10 2018, 9:24 AM
Closed by commit R169:18228385e172: Fix warning (authored by apol). · Explain WhyApr 10 2018, 6:50 PM
This revision was automatically updated to reflect the committed changes.
mart added a comment.Apr 11 2018, 10:44 AM

this actually breaks correct reparenting of items in pages, the sheet in the button gallery goes now on top of the action button.

Revision Contents
Changeset List

PathPackages
Msrc/controls/ScrollablePage.qml (3 lines)

Diff 31832

View Options

src/controls/ScrollablePage.qml

Loading...