Differential D12070

Fix default Find My Phone ringtone
ClosedPublic
Actions

Authored by mtijink on Apr 9 2018, 4:06 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R225:2cd7d4b7a99a: Fix default Find My Phone ringtone
Summary

Previously, if the user hadn't set a ringtone, the code raised an exception (because an empty string isn't an uri). Thus, no sound was played.

This fixes it.

BUG: 392853

Test Plan

Without having set a ringtone, it works. Otherwise, it works too.

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mtijink created this revision.Apr 9 2018, 4:06 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptApr 9 2018, 4:06 PM
mtijink requested review of this revision.Apr 9 2018, 4:06 PM
albertvaka accepted this revision.Apr 9 2018, 4:32 PM
This revision is now accepted and ready to land.Apr 9 2018, 4:32 PM
sredman added a subscriber: sredman.Apr 9 2018, 4:33 PM

Albert beat me to it, but it works for me!

nicolasfella added a subscriber: nicolasfella.Apr 9 2018, 4:53 PM

Thanks, sadly it's too late for 1.3 :(
IMHO this should be part of a 1.3.1 release because it breaks the feature by default

mtijink added a comment.Apr 9 2018, 5:00 PM
In D12070#243282, @nicolasfella wrote:

Thanks, sadly it's too late for 1.3 :(
IMHO this should be part of a 1.3.1 release because it breaks the feature by default

This is Android-only, so that shouldn't matter (it also breaks for 1.2.1 desktop).

Closed by commit R225:2cd7d4b7a99a: Fix default Find My Phone ringtone (authored by mtijink). · Explain WhyApr 9 2018, 5:02 PM
This revision was automatically updated to reflect the committed changes.
nicolasfella added a comment.Apr 9 2018, 5:03 PM
In D12070#243288, @mtijink wrote:
In D12070#243282, @nicolasfella wrote:

Thanks, sadly it's too late for 1.3 :(
IMHO this should be part of a 1.3.1 release because it breaks the feature by default

This is Android-only, so that shouldn't matter (it also breaks for 1.2.1 desktop).

You're right, stupid me

Revision Contents
Changeset List

Diff 31753

View Options

src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhoneActivity.java

Loading...