Differential D12065

Fix update of the preset editor GUI when a default preset is created
ClosedPublic
Actions

Authored by dkazakov on Apr 9 2018, 11:56 AM.

Details

Reviewers
scottpetrovic
Group Reviewers
Krita
Commits
R37:69a4f5f459e7: Fix update of the preset editor GUI when a default preset is created
R37:5cbd4c8cdfca: Fix update of the preset editor GUI when a default preset is created
Summary

Before the patch, preset editor's GUI was set to the previous
paintop type, which was incorrect. I'm not entirely sure that
this fix is correct, so putting it for review.

CCBUG:392869

Test Plan
  1. Press "New default preset"
  2. See that the GUI updated correctly

Questions:

  1. Is it really default preset got loaded? Or something else?

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dkazakov requested review of this revision.Apr 9 2018, 11:56 AM
dkazakov created this revision.
scottpetrovic accepted this revision.Apr 9 2018, 1:47 PM

Looks good to me. I was sure that was working when Wolthera originally added that. Something must have gotten messed up with a merge or something. Thanks for the patch. Push it!

This revision is now accepted and ready to land.Apr 9 2018, 1:47 PM
Closed by commit R37:5cbd4c8cdfca: Fix update of the preset editor GUI when a default preset is created (authored by dkazakov). · Explain WhyApr 9 2018, 1:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlibs/ui/kis_paintop_box.cc (4 lines)

Diff 31741

View Options

libs/ui/kis_paintop_box.cc

Loading...