Differential D12061

Changed loading of layout.xml from resource system only
ClosedPublic
Actions

Authored by nmel on Apr 9 2018, 7:07 AM.

Details

Reviewers
martinkostolny
Group Reviewers
Krusader
Commits
R167:21b8a447187b: Changed loading of layout.xml from resource system only
Summary

layout.xml is static file, so it's safe to load it from resource.
In the same time, if layout.xml is changed like it happened after v2.6,
this way doesn't introduce problems with loading incorrect layout.
Incorrect layout was loaded incorrectly if v2.6 is installed through
package manager and we run locally compiled / installed exe.

FIXED: [ 386314 ] Install to a custom location doesn't work correctly
BUG: 386314

Diff Detail

Repository
R167 Krusader
Branch
fix-layout-loading
Lint
No Linters Available
Unit
No Unit Test Coverage
nmel requested review of this revision.Apr 9 2018, 7:07 AM
nmel created this revision.
martinkostolny accepted this revision as: martinkostolny.Apr 9 2018, 10:39 PM
martinkostolny added a subscriber: martinkostolny.

Thanks, Nikita!

This revision is now accepted and ready to land.Apr 9 2018, 10:39 PM
Closed by commit R167:21b8a447187b: Changed loading of layout.xml from resource system only (authored by nmel). · Explain WhyApr 10 2018, 5:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31720

View Options

krusader/Panel/krlayoutfactory.h

Loading...
View Options

krusader/Panel/krlayoutfactory.cpp

Loading...