Make automounting work even if StorageAccess is ignored
ClosedPublic

Authored by bruns on Apr 8 2018, 8:25 PM.

Details

Summary

There is no reason to make mounting dependent on the StorageAccess.ignore
flag, which just serves a a hint for visualization.

This change sneaked in when porting to KF5, no justification given.

BUG: 389479

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Apr 8 2018, 8:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 8 2018, 8:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bruns requested review of this revision.Apr 8 2018, 8:25 PM

Did you mean BUG: 391706?

bruns added a comment.EditedApr 8 2018, 8:31 PM

Did you mean BUG: 391706?

No, this commit *fixes* 389479, but it is a prerequisite for fixing 391706 (which is essentially a revert, thus would regress 389479).

EDIT: I can add 391706 as CCBUG ...

I did the KF5 port but I don't recall doing that or why it would be there, so +1 from me if it fixes that. I don't use automounter so I don't know

ngraham accepted this revision.Apr 9 2018, 1:02 AM

Land on the 5.12 branch, please.

This revision is now accepted and ready to land.Apr 9 2018, 1:02 AM
This revision was automatically updated to reflect the committed changes.

Can you make sure this ends up on the 5.12 branch too?

bruns added a comment.Apr 9 2018, 1:11 AM

damn, that did not work as expected ... landed on master
should I just "arc land --onto Plasma/5.12" ?

Well it's too late now, but yes, that would have worked (in general, make sure to look before you land by first doing arc land --preview <any other options>). By default, arc lands the diff on the parent branch, which in this case was master.

Arc documentation is at https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches

For now, you can cherry-pick the commit onto the 5.12 branch.

bruns added a comment.Apr 9 2018, 1:15 AM

Well, I really do not like what arc is doing behind my back ...

Well, I really do not like what arc is doing behind my back ...

It irritated me too at first, but over time I found that it's fairly logical. In general, you just need to:

  • Always preview with arc land --preview before you land, to make sure you know what arc is going to do
  • Always make a branch; don't diff from master
  • Always branch from the branch that you want to land it on
  • If you change your mind later and decide to land on a different branch, re-base the commit prior to landing it: git rebase --onto origin/<branch> master

I really do recommend having a look at https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches. I and others have done a lot of work to document the behavior so that using arc shouldn't feel like a huge headache anymore.