- Colorize output
- Improve help message
Details
Details
- Reviewers
ngraham - Group Reviewers
Baloo - Maniphest Tasks
- T8250: Sanitize the database
$ baloodb Diff Detail
Diff Detail
- Repository
- R293 Baloo
- Branch
- sanitize-improve-ui (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
This is the last patch, before I let baloodb rest for some time.
This is the first time I've created a cli-tool + class completely from scratch. So there a tendency to become routine-blinded ("betriebsblind"). Therefore I'd like to ask you to check for
- overall consistency
- proper wording
- expressiveness of names: commands, command options, functions, variables.
- usefulness of coloring
command options:
- -D is fixed
- -d is forbidden to avoid confusion
- -o is reserved for maybe --output
Everything else is completely changeable.
I'm looking forward to your comments and suggestions.
To see this at work you can ruin your database as described in T7860 or do
$ md /tmp/ottoCopy some files into /tmp/otto
$ balooctl index /tmp/otto/* $ balooctl stop $ rm /tmp/otto/*
baloodb works without the indexer running.
| src/engine/databasesanitizer.cpp | ||
|---|---|---|
| 249–253 ↗ | (On Diff #31684) | code uniformity - I prefer it as written in line 285 (acessible check first) |
| 323–324 ↗ | (On Diff #31684) | long line, remove the format string and use operator<< for each argument |
| src/engine/databasesanitizer.h | ||
| 85 ↗ | (On Diff #31684) | Instead of the outermost pair, just use a plain array - the types of all elements are uniform |