Details
- Reviewers
kfunk - Commits
- R877:a051c75b1ee9: Add umbrello
Diff Detail
- Repository
- R877 Craft Blueprints for KDE
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
I'll leave this to those more involved with Craft and it's Blueprints to review however I do see that you are using kdevplatform here - please note that it was merged into KDevelop a while back and therefore no longer exists. I'm not sure to what degree this is reflected in Craft though.
kdevplatform has been added to umbrello 3 month before the mentioned merge and I was suprised that this happened. I guess a possible way would be to add a BUILD_KDEVPLATFORM_ONLY or similar flag cmake to kdevelop source to be able to create a separate kdevplatform package.
You would need to check with the appropriate Blueprints and amend appropriately in that instance.
As @vonreth is the maintainer of the Blueprints, and @kfunk has done quite a bit of work in relation to the Binary Factory i'll leave the review of this to them as they are significantly more familiar with how it works than I am.
I'm going to apply this patch with the mentioned changes applied.
| kde/kdesdk/umbrello/umbrello.py | ||
|---|---|---|
| 39 | According to https://cgit.kde.org/craft-blueprints-kde.git/tree/extragear/kdevelop-pg-qt this should be named kdevelop-pg-qt. | |
| 40 | To be in sync with other kdevelop related packages this should be named kdevelop-php | |
| kde/kdesdk/umbrello/umbrello.py | ||
|---|---|---|
| 13 | This package seems not to be present on craft. According to an obs build (https://build.opensuse.org/public/build/home:rhabacker:branches:windows:mingw:win32:KF5Apps/openSUSE_Leap_42.3/x86_64/mingw32-umbrello5/_log) it is added because some packages depends on it (search for mingw32-libintl-devel). | |
| kde/kdesdk/umbrello/umbrello.py | ||
|---|---|---|
| 13 | libintl is part of gettext, and is therefore already provided. In regards to what the CI system has, please see the file craftmaster/packages.list in the sysadmin/ci-tooling repository for what is installed on the CI nodes. | |
| kde/kdesdk/umbrello/umbrello.py | ||
|---|---|---|
| 13 | Thanks for this pointer - on obs libintl package is separated from the gettext package, see https://build.opensuse.org/package/view_file/windows:mingw:win32/mingw32-gettext/mingw32-gettext.spec?expand=1 | |