Immediately apply termInConstruction when term is complete
ClosedPublic

Authored by bruns on Apr 8 2018, 12:46 AM.

Details

Summary

Term::Or and Term::And delimit the term in construction, but did not
add the term to the stack. This necessitated to save the last seen
operation, but use the previous operation from the stack when adding
to it. Unfortunately the last seen operation was not restored correctly
after pushing and popping from the stack.

Instead of adding more state to the parser, immediately add a completed
term to the stack, which allows to remove the temporary last operation.

Test Plan

ctest

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Apr 8 2018, 12:46 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 8 2018, 12:46 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
bruns requested review of this revision.Apr 8 2018, 12:46 AM
bruns updated this revision to Diff 31638.Apr 8 2018, 1:07 AM

rebase

bruns removed a task: Restricted Maniphest Task.Apr 8 2018, 1:08 AM
michaelh accepted this revision as: michaelh.Apr 8 2018, 10:43 AM

"Immediately add term to stack when it is complete" as commit message?

This revision is now accepted and ready to land.Apr 8 2018, 10:43 AM
This revision was automatically updated to reflect the committed changes.