Change "different user" icon on login screen
ClosedPublic

Authored by sharvey on Apr 8 2018, 12:43 AM.

Details

Summary

Replace "different user" icon on SDDM login screen to match icon used on
unlock screen. Original icon was system-search, now changed to system-switch-user.

BUG: 392830

Test Plan
  • Recompile plasma-workspace
  • Log out of current session
  • Check that Different User icon is now a figure with an arrow

Diff Detail

Repository
R120 Plasma Workspace
Branch
change-user-icon (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
sharvey created this revision.Apr 8 2018, 12:43 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 8 2018, 12:43 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sharvey requested review of this revision.Apr 8 2018, 12:43 AM
sharvey edited the test plan for this revision. (Show Details)Apr 8 2018, 12:44 AM
sharvey added a reviewer: VDG.
sharvey added a subscriber: VDG.
ngraham accepted this revision.Apr 8 2018, 3:47 AM
ngraham added reviewers: Plasma, davidedmundson.
ngraham added a subscriber: davidedmundson.

I think I understand why the icons are currently different: because the functionalities are different! In the lock screen, clicking on that button/icon switches to another visible user. In the Login screen, it lets you find other users not listed there to log in as.

However, the the distinction is basically academic in the average user's mind, and the objective of both is to log in as a different user from the one that's been presented to you. Furthermore, the lock screen icon honestly does seem to fit both use cases, if you consider that each one is a subtle variation of "log in as some other user".

Therefore thumbs up from me. Let's let Plasma folks weigh in too, and especially @davidedmundson, who's the guardian of the SDDM theme.

This revision is now accepted and ready to land.Apr 8 2018, 3:47 AM
ngraham edited the summary of this revision. (Show Details)Apr 8 2018, 3:47 AM
In the Login screen, it lets you **//find//** other users not listed there to log in as.

With all due respect to the designers, I never made that connection.

I know the one you selected is named system-switch-users, but there's also this one, named system-users:

It doesn't have the arrow (which connotes action), but it clearly demonstrates "multiple people", another valid metaphor.

It's simple enough to change if the reviewers like it better.

sharvey added a subscriber: sebas.Apr 8 2018, 4:26 PM

PS: Credit to @sebas for making Cuttlefish!

davidedmundson accepted this revision.Apr 8 2018, 4:28 PM

Let's stay with system-switch-user for now and see how that goes.

This revision was automatically updated to reflect the committed changes.