Differential D12032

Tweak README-KeyTab and README.keyboard a bit
ClosedPublic
Actions

Authored by ahmadsamir on Apr 7 2018, 7:43 PM.

Details

Reviewers

hindenburg

Group Reviewers

Konsole

Commits

R319:1ec394b9e7c6: Tweak README-KeyTab and README.keyboard a bit

Summary

Rename README.KeyTab to README-KeyTab to prevent Konsole from trying to
load it as a keyboard translator file, and fix references to that file
name in other files.

Flesh out README-KeyTab and README.keyboard and reformat them.

Also copy the the original README-KeyTab to README-KeyTab-original,
just in case there's some concept that I misinterpretted/misunderstood.

Diff Detail

Repository

R319 Konsole

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ahmadsamir created this revision.Apr 7 2018, 7:43 PM

Restricted Application added a project: Konsole. · View Herald TranscriptApr 7 2018, 7:43 PM

ahmadsamir requested review of this revision.Apr 7 2018, 7:43 PM

also while we are here, we need to rename this to something other than .keytab since the Konsole code tries to load it as a valid keytab

org.kde.konsole: Unable to load translator "README" file.

data/keyboard-layouts/README-KeyTab-original
5	I would not hard-code these paths - see https://doc.qt.io/qt-5/qstandardpaths.html

Rename README.KeyTab to README-KeyTab to prevent Konsole from trying to load it as a keyboard translator file.

ahmadsamir marked an inline comment as done.Apr 12 2018, 5:58 PM

Ok I looked at this again, the README.keytab is not installed/packaged - I'm not sure how it got copied to the konsole folder on my system. I'm fine w/ the renaming part though.

Regardless, the normal user will not have the README-KeyTab installed - only those that have the source.

hindenburg accepted this revision.Apr 13 2018, 12:43 PM

This revision is now accepted and ready to land.Apr 13 2018, 12:43 PM

Closed by commit R319:1ec394b9e7c6: Tweak README-KeyTab and README.keyboard a bit (authored by ahmadsamir, committed by hindenburg). · Explain WhyApr 13 2018, 12:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
A	M	data/keyboard-layouts/README-KeyTab (78 lines)
V		data/keyboard-layouts/{README-KeyTab-original ← README.KeyTab}
V		data/keyboard-layouts/{README.KeyTab → README-KeyTab-original}
M		data/keyboard-layouts/default.keytab (7 lines)
M		doc/user/README.keyboard (24 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	31624	f9d3b79		Apr 7 2018, 7:43 PM	★	★
Diff 2	31986	8254dd0	Rename README.KeyTab to README-KeyTab to prevent Konsole from trying to load it…	Apr 12 2018, 5:57 PM	★	★
Diff 3	32057	6b1d799	R319:1ec394b9e7c6f1f1651e9d9332604f4df9033dce	Apr 13 2018, 12:44 PM	★	★