Differential D12029

taglibextractor: Fix empty genre bug
ClosedPublic
Actions

Authored by michaelh on Apr 7 2018, 7:08 PM.

Details

Reviewers
mgallien
Group Reviewers
Baloo
Frameworks
Commits
R286:d66b9853b55d: taglibextractor: Fix empty genre bug
Summary

Depends on D12028

Test Plan

make test

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
michaelh created this revision.Apr 7 2018, 7:08 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 7 2018, 7:08 PM
michaelh requested review of this revision.Apr 7 2018, 7:08 PM
mgallien accepted this revision.Apr 11 2018, 12:00 PM

Sorry for the delay. Thanks

This revision is now accepted and ready to land.Apr 11 2018, 12:00 PM
michaelh added a comment.Apr 11 2018, 12:02 PM
In D12029#244237, @mgallien wrote:

Sorry for the delay. Thanks

No Problem. Thanks you. Have you noticed this is part of a stack?

michaelh updated this revision to Diff 32050.Apr 13 2018, 11:10 AM
  • Rebase and adapt
Closed by commit R286:d66b9853b55d: taglibextractor: Fix empty genre bug (authored by michaelh). · Explain WhyApr 13 2018, 11:15 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32051

View Options

autotests/taglibextractortest.cpp

Loading...
View Options

src/extractors/taglibextractor.cpp

Loading...