The code merged compatible terms only if the left hand side was a list of
subterms (i.e. it worked for "a AND b AND (c AND d)", but not
"b AND (c AND d)"). Instead of duplicating code, just use the
Term(Term, Operation, Term) constructor, which handles merging.
Details
Details
- Reviewers
michaelh - Group Reviewers
Baloo - Commits
- R293:c91c43393c33: Fix merging of terms in the AdvancedQueryParser
ctest -V -R advancedqueryparser
38: QDEBUG : AdvancedQueryParserTest::testNestedParentheses((a AND (b AND (c AND d)))) result term ( AND ( : a (QString)) ( : b (QString)) ( : c (QString)) ( : d (QString)) ) 38: QDEBUG : AdvancedQueryParserTest::testNestedParentheses((a AND (b AND (c AND d)))) expected term ( AND ( : a (QString)) ( : b (QString)) ( : c (QString)) ( : d (QString)) ) 38: PASS : AdvancedQueryParserTest::testNestedParentheses((a AND (b AND (c AND d))))
Diff Detail
Diff Detail
- Repository
- R293 Baloo
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
lgtm. Please rebase (preferrably after landing D11826), so I can run the test.
Cherry Pick Failed! Exception Command failed with error #1! COMMAND git cherry-pick 'arcpatch-D11907'