Differential D12000

[ProcessModel] Return invalid QVariant() for when window is not known
ClosedPublic
Actions

Authored by broulik on Apr 6 2018, 9:48 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R111:e3ea3c840d6f: [ProcessModel] Return invalid QVariant() for when window is not known
Summary

This communicates "unknown" better than a zero. The KSysGuardProcessList also seems to expect this.

Test Plan

I no longer get a non-working "Show Application Window" in context menu for processes that don't have a window associated with them.

Diff Detail

Repository
R111 KSysguard Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 6 2018, 9:48 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 6 2018, 9:48 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 6 2018, 9:48 PM
davidedmundson accepted this revision.Apr 6 2018, 10:05 PM
This revision is now accepted and ready to land.Apr 6 2018, 10:05 PM
Closed by commit R111:e3ea3c840d6f: [ProcessModel] Return invalid QVariant() for when window is not known (authored by broulik). · Explain WhyApr 9 2018, 9:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mprocessui/ProcessModel.cpp (2 lines)

Diff 31730

View Options

processui/ProcessModel.cpp

Loading...