Fix warning
ClosedPublic
Actions

Authored by apol on Apr 6 2018, 5:45 PM.

Details

Reviewers

mart

Group Reviewers

Kirigami

Commits

R858:9c0c690188a7: Fix warning

Summary

.../qml/QtQuick/Controls.2/org.kde.desktop/ToolBar.qml:37: ReferenceError: is is not defined

Test Plan

Now Discover still works, I'm not sure how to test it specificly. It
doesn't look like it was doing anything before though.

Repository

R858 Qt Quick Controls 2: Desktop Style

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

apol requested review of this revision.Apr 6 2018, 5:45 PM

mart accepted this revision.Apr 9 2018, 3:30 PM

This revision is now accepted and ready to land.Apr 9 2018, 3:30 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			org.kde.desktop/ToolBar.qml (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	31510	9ae3088		Apr 6 2018, 5:45 PM	★	★
Diff 2	31789	3c41862	R858:9c0c690188a777824ec3e7018e1de324e6ea7f37	Apr 10 2018, 7:43 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
d4d7f021ead5	310cf98cb711	9ae3088ffb34	Aleix Pol	Fix warning (Show More…)	Apr 6 2018, 5:44 PM