Differential D11989

[Notifications] Always scroll to the top when opening
ClosedPublic
Actions

Authored by broulik on Apr 6 2018, 3:39 PM.

Details

Reviewers
davidedmundson
fabianr
Group Reviewers
Plasma
VDG
Commits
R120:19332567dce6: [Notifications] Always scroll to the top when opening
Summary

The more important recent stuff is at the top.

BUG: 391646
FIXED-IN: 5.12.5

Test Plan

Spawned a gazilion notifications, opened notifications, was scrolled at the top.
Scrolled down, closed, opened, back at the top now
Spawned a persistent noficiation, opened notification, was at the top and notification was in visible area

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 6 2018, 3:39 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 6 2018, 3:39 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 6 2018, 3:39 PM
broulik updated this revision to Diff 31501.Apr 6 2018, 3:44 PM
  • Also use positionViewAtBeginning as contentY alone doesn't really work with the way ListView works
davidedmundson added a subscriber: davidedmundson.Apr 6 2018, 10:12 PM

If you're working round a Qt bug, I'd like a bug reported and in the comment please

applets/notifications/package/contents/ui/main.qml
82

have you tried just

contentY = originY?

broulik updated this revision to Diff 33050.Apr 25 2018, 9:06 AM
  • Use originY
davidedmundson accepted this revision.Apr 25 2018, 9:20 AM
This revision is now accepted and ready to land.Apr 25 2018, 9:20 AM
fabianr accepted this revision.Apr 25 2018, 9:28 AM
Closed by commit R120:19332567dce6: [Notifications] Always scroll to the top when opening (authored by broulik). · Explain WhyApr 25 2018, 9:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33052

View Options

applets/notifications/package/contents/ui/main.qml

Loading...