Differential D11983

[potd wallpaper] Config UI: fix spacing between UI elements
ClosedPublic
Actions

Authored by kossebau on Apr 6 2018, 12:12 PM.

Details

Reviewers
xuetianweng
ngraham
davidedmundson
Commits
R114:c114e392eab8: Merge branch 'Plasma/5.12'
R114:458f4387f825: [potd wallpaper] Config UI: fix spacing between UI elements

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Apr 6 2018, 12:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 6 2018, 12:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kossebau requested review of this revision.Apr 6 2018, 12:12 PM
kossebau updated this revision to Diff 31481.Apr 6 2018, 12:15 PM

add missing bump of QtQuick.Controls version for autoresize of comboboxes

davidedmundson added a subscriber: davidedmundson.Apr 6 2018, 12:22 PM
davidedmundson added inline comments.
wallpapers/potd/contents/ui/config.qml
66
This comment has been deleted.
kossebau added a comment.Apr 6 2018, 12:41 PM

It's saying the maximum size is the size it currently is; which is true for all values simultaneously.

The idea is to make sure the size stays at the value calculated by formAlignment - units.largeSpacing (formAlignment being injected here by the wallpaper config container to ensure aligned style).

What other approach would you recommend? doing some global property labelWidth which then is set to formAlignment - units.largeSpacing, and then setting all the Layout.minimumWidth & Layout.maximumWidth: to that?

kossebau updated this revision to Diff 31486.Apr 6 2018, 1:08 PM

one step at a time: keep old Rows and just switch to ColumnLayout

kossebau added a comment.Apr 6 2018, 1:12 PM

Guess I better leave the rows as they are, to also follow current config UI logic of the plasma-workspace wallpaper plugins.
But fixing at least the missing vertical spacing, making it look like this:

Candidate for 5.12, as fix for UI glitch?

ngraham accepted this revision.Apr 6 2018, 1:13 PM
ngraham added a subscriber: ngraham.

That looks sane to me visually. The QML change is sane too.

This revision is now accepted and ready to land.Apr 6 2018, 1:13 PM
davidedmundson accepted this revision.Apr 6 2018, 1:15 PM
Closed by commit R114:458f4387f825: [potd wallpaper] Config UI: fix spacing between UI elements (authored by kossebau). · Explain WhyApr 6 2018, 2:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31494

View Options

wallpapers/potd/contents/ui/config.qml

Loading...