src/file/basicindexingjob.cpp
54	Unneeded conversion, filePathToStat takes QByteArray
src/file/fileinfo.cpp
31	dito
src/kioslaves/search/kio_search.cpp
96–97	Temporary variable url = encodeName(filePath), like above?
src/kioslaves/timeline/kio_timeline.cpp
83–84	dito

michaelh marked 4 inline comments as done.Apr 6 2018, 7:30 PM

This obviously needs some cleanup, but this should not hold up this request ...

We should check if instead of replicating the code in the individual ioslaves we could push the createFileUdsEntry to the ResultIterator.

This revision is now accepted and ready to land.Apr 7 2018, 9:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/engine/idutils.h (38 lines)
M			src/file/basicindexingjob.cpp (2 lines)
M			src/file/fileinfo.cpp (5 lines)
M			src/kioslaves/search/kio_search.cpp (4 lines)
M			src/kioslaves/timeline/kio_timeline.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	31474	7836290		Apr 6 2018, 11:33 AM	★	★
Diff 2	31515	7836290	- Apply suggested changes	Apr 6 2018, 7:28 PM	★	★
Diff 3	31561	1ea0b94	- Correct typo	Apr 7 2018, 6:22 AM	★	★
Diff 4	31671	04f972a	R293:b94a91a556b5f7deda83ff56e76060c6b6703756	Apr 8 2018, 2:31 PM	★	★