[Image Wallpaper] Fix blur
ClosedPublic

Authored by broulik on Apr 6 2018, 9:05 AM.

Details

Summary

This broke in the transition to StackView as the blur needs a full-size source. Additionally

  • put the item into a Loader to avoid needless shader compilation and other work
  • only load the blur for image fill modes where the image does not cover the full size
  • don't render background color when blur is enabled as you cannot see it anyway
Test Plan
  • Enabled and disabled blur, verified that the Loader loads and unloads
  • Switched between fill modes, verified that the Loader loads and unloads
  • Verified that blur renders correctly and looks nice

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Apr 6 2018, 9:05 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 6 2018, 9:05 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 6 2018, 9:05 AM
broulik updated this revision to Diff 31468.
  • Always render background when blur is not loaded regardless of why (fill mode or config)
  • use PreserveAspectCrop for blur as it was in the old code
davidedmundson accepted this revision.Apr 10 2018, 12:44 PM
This revision is now accepted and ready to land.Apr 10 2018, 12:44 PM
This revision was automatically updated to reflect the committed changes.