Improve the default settings of glide effect to remove the angle and appear from above and disappear to below
Diff Detail
- Repository
- R108 KWin
- Branch
- glide_defaults_change (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage
glide effect to remove the angle and appear from above and disappear to below
I thought that[having angle] was the point of the glide effect.
With these new params it looks pretty much like a scale effect.
It was to be similar to scale effect, but scale effect only "appears", doesnt animate closing. Also with the purpose to "appear from below" or "appear from above" to be configurable. I actually never used it as "rotation of windows"!
-1, sorry. (please notice that I'm not a member of KWin so you shouldn't worry what I think ;-)
Having tilt is one of the purposes(or key components) of the glide effect. IIRC Glide 1 from Compiz also has some angle.
Tilt nowadays may be too much wobbly , and being default the user might be put off immediatly. Btw tilt was not one of the original purposes of Glide. At least not when I developed it.
Well ... more or less ... what i liked on that compiz effect was the appear and disappear, above and below ( for open and close, not just open ). That was what I wanted when I did it. Compiz Glide also had that tilt so I did it also.
I don't really know if removed the default tilt is correct or not according to the "name glide", but i am trying to make the effect more appealing and "easier" to new users. Like always, kwin team knows best, whatever they thinks its good.
sorry if not a constructive patch :(
As you work through this, can you please also upload videos to understand the changes visually too?
The idea how the glide effect was implemented is to have this angle. The defaults have not been changed since the effect got introduced.
As this is an effect not enabled by default I do not see the need to change any default settings.
It was not, I started this effect's development mostly because scale effect only did openning window and not closing one. compiz did both and it was much cooler to me.
The defaults have not been changed since the effect got introduced.
Yeah true. I guess its fair and i deserve that, I completly just abandoned the effect development and had years and years to change it, but i didn't.
The reason why its a slider with that value is because at the time I didn't knew better. The proper way should be a way to select "Appear -> Above/Below" , "Dissapear -> Above/Below". I should have done a "Duration" box like some effects have also.
Anyway, sorry for wasting your guys time and Thanks for your work on KDE!
What I like about Compiz is that in Compiz that's very easy to have different animations when the window is minimized, maximized, closed, etc. I wish we could have something similar in KWin. E.g. I would like to have Glide effect when unminiminizing windows (like in Unity).
Given that the effect was rewritten quite substantially, I think this change is no longer actual.
Requesting changes, to remove from review queue.