Differential D11971

Use same keyword separator for read and write
ClosedPublic
Actions

Authored by michaelh on Apr 5 2018, 8:23 PM.

Details

Reviewers
leinir
danders
Group Reviewers
Calligra: 3.0
Commits
R8:e52edfd1b50f: D11971: Use same keyword separator for read and write

Diff Detail

Repository
R8 Calligra
Branch
keyword-separator
Lint
No Linters Available
Unit
No Unit Test Coverage
michaelh created this revision.Apr 5 2018, 8:23 PM
Restricted Application added a project: Calligra: 3.0. · View Herald TranscriptApr 5 2018, 8:23 PM
michaelh requested review of this revision.Apr 5 2018, 8:23 PM
michaelh added a comment.Apr 5 2018, 8:25 PM

Hi!
Regard this as a bug report, please. I did not test, not even built it, because calligra is too large for my little machine.
Hope this is useful.

michaelh updated this revision to Diff 31423.Apr 5 2018, 8:35 PM
  • Add semicolons
Restricted Application added a subscriber: Calligra-Devel-list. · View Herald TranscriptJul 30 2018, 4:47 AM
anthonyfieroni added a comment.Mar 22 2019, 1:22 PM

Ping this looks sane, anyone ?

danders added a comment.Mar 25 2019, 9:08 AM

Yes, looks sane, I'll deal with it.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 25 2019, 1:49 PM
Closed by commit R8:e52edfd1b50f: D11971: Use same keyword separator for read and write (authored by danders). · Explain Why
This revision was automatically updated to reflect the committed changes.
danders mentioned this in R8:e52edfd1b50f: D11971: Use same keyword separator for read and write.

Revision Contents
Changeset List

Diff 31421

View Options

libs/main/tests/documentstructuretest.cpp

Loading...
View Options

libs/odf/KoDocumentInfo.h

Loading...
View Options

libs/odf/KoDocumentInfo.cpp

Loading...
View Options

plan/src/libs/odf/KoDocumentInfo.h

Loading...
View Options

plan/src/libs/odf/KoDocumentInfo.cpp

Loading...