More interface stuttering work
ClosedPublic

Authored by malteveerman on Apr 5 2018, 6:01 PM.

Details

Summary

This includes the C++ implementation of the lyrics functionality, which is now async. Also includes a fix for SqlAlbumTest, which failed since my last stuttering revision.
The biggest change though is in CollectionTreeItemModelBase. It now loads an album's tracks in a Threadweaver job and CollectionSortFilterProxyModel filters unloaded albums. This makes the CollectionTreeView seem to grow when expanding an artist with many albums like "Various Artists" instead of freezing for a while depending on your collection size. The CollectionTreeView must be set to display album years for this to take effect.

Diff Detail

Repository
R181 Amarok
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
malteveerman requested review of this revision.Apr 5 2018, 6:01 PM
malteveerman created this revision.

Added a few random improvements and compilation warning fixes.

markey accepted this revision.Apr 12 2018, 4:31 PM
This revision is now accepted and ready to land.Apr 12 2018, 4:31 PM
markey closed this revision.Apr 12 2018, 4:32 PM