Differential D11955

[Folder View] Set Refresh shortcut on Refresh/Reload
ClosedPublic
Actions

Authored by broulik on Apr 5 2018, 12:09 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:9a333b48ca1a: [Folder View] Set Refresh shortcut on Refresh/Reload
Summary

Also remove the "reload" action as the "refresh" action is being used in both cases and setup by usedByContainment

CCBUG: 392730

Test Plan
  • Refresh or Reload now show F5 in the context menu
  • Verified that F5 still reloads the correct focused FolderView and that both Refresh (containment) and Reload (applet) work

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 5 2018, 12:09 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 5 2018, 12:09 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 5 2018, 12:09 PM
hein accepted this revision.Apr 5 2018, 1:05 PM

Could you add a code comment about why this is not an issue, similar to the description? If two far-removed places of code depend on each other indirectly and by design it warrants a comment so future developers have a chance to keep it working.

This revision is now accepted and ready to land.Apr 5 2018, 1:05 PM
broulik planned changes to this revision.Apr 9 2018, 2:26 PM

I just noticed that setUsedByContainment actually renames the "reload" action to "Refresh desktop", so "refresh" is essentially useless.
Will refactor this to get rid of the dedicated "Refresh" action and just use "Reload" everywhere (with appropriate name as is currently done in the code already)

broulik updated this revision to Diff 32995.Apr 24 2018, 4:39 PM
broulik edited the summary of this revision. (Show Details)
  • Drop "reload" action
This revision is now accepted and ready to land.Apr 24 2018, 4:39 PM
hein accepted this revision.Apr 24 2018, 4:52 PM
Closed by commit R119:9a333b48ca1a: [Folder View] Set Refresh shortcut on Refresh/Reload (authored by broulik). · Explain WhyApr 24 2018, 5:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33001

View Options

containments/desktop/plugins/folder/autotests/foldermodeltest.cpp

Loading...
View Options

containments/desktop/plugins/folder/foldermodel.cpp

Loading...