Differential D11933

Only do fuzzy path matching on the very last path/filter segments
ClosedPublic
Actions

Authored by mwolff on Apr 4 2018, 8:19 PM.

Details

Reviewers

Commits

R32:5b9b5c1e1a01: Only do fuzzy path matching on the very last path/filter segments

Summary

The old code joined all filter segments and then used that to match
it against the last path segment. This is quite odd behavior, imo:
If I type "foo/bar", then I wouldn't expect it to match a file called
"fooXbar". On the other hand, I would expect "foo/bar" to fuzzy-match
"foo/xBxAxRx", since the "foo" segment is matched and then "bar" is
fuzzy-matched against the "xBxAxRx" segment.

The new tests fuzzy2, fuzzy3 and fuzzy5 fail with the old code but
pass with the new, simplified code.

Diff Detail

Repository

R32 KDevelop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mwolff created this revision.Apr 4 2018, 8:19 PM

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptApr 4 2018, 8:19 PM

mwolff requested review of this revision.Apr 4 2018, 8:19 PM

I remember seeing this odd behaviour as well. I agree, the changed version makes more sense.

This revision is now accepted and ready to land.Apr 4 2018, 8:34 PM

Closed by commit R32:5b9b5c1e1a01: Only do fuzzy path matching on the very last path/filter segments (authored by mwolff). · Explain WhyApr 4 2018, 9:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kdevplatform/language/interfaces/abbreviations.h (3 lines)
M			kdevplatform/language/interfaces/abbreviations.cpp (17 lines)
M			kdevplatform/language/interfaces/quickopenfilter.h (5 lines)
M			plugins/quickopen/tests/test_quickopen.cpp (29 lines)