Switch to the KItinerary library
ClosedPublic

Authored by vkrause on Apr 4 2018, 7:41 PM.

Diff Detail

Repository
R81 KDE PIM Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Apr 4 2018, 7:41 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 4 2018, 7:41 PM
vkrause requested review of this revision.Apr 4 2018, 7:41 PM
mlaurent accepted this revision.Apr 5 2018, 6:14 AM
This revision is now accepted and ready to land.Apr 5 2018, 6:14 AM
knauss accepted this revision.Apr 5 2018, 6:39 AM
knauss added a subscriber: knauss.

mmh this is not very easy to see what are the changes. Because of the many files disappearing.
I found 8 files that are touched and not deleted. Looks fine so far.

But please next time split the review request into one, that is worth looking and only mention that you will delete files.

mmh this is not very easy to see what are the changes. Because of the many files disappearing.
I found 8 files that are touched and not deleted. Looks fine so far.

But please next time split the review request into one, that is worth looking and only mention that you will delete files.

Sorry, I should have been clear that the point of this review was not to look at the extremely straightforward code changes, but to approve the new dependency. Obviously this will only be integrated once the entire move procedure for KItinerary is completed.

This revision was automatically updated to reflect the committed changes.