Differential D11923

Avoid pointless config parse in ksplash
ClosedPublic
Actions

Authored by davidedmundson on Apr 4 2018, 1:24 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R120:3b02ff3c1706: Avoid pointless config parse in ksplash
Summary

Due to the nature of cascading configs we have already loaded and parsed
kdeglobals, it's wasteful to do it again. Especially in ksplash where startup time is important.

Test Plan

Changed lnf to org.obnosim.tweak.desktop which contains a new splash
Logged out and back in. Still got a different splash.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Apr 4 2018, 1:24 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 4 2018, 1:24 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Apr 4 2018, 1:24 PM
broulik accepted this revision.Apr 4 2018, 1:37 PM
broulik added a subscriber: broulik.

The same is also done in plasmashell, krunner, etc, probably a copy-paste thing. Not sure it had a deeper meaning?

This revision is now accepted and ready to land.Apr 4 2018, 1:37 PM
Closed by commit R120:3b02ff3c1706: Avoid pointless config parse in ksplash (authored by davidedmundson). · Explain WhyApr 4 2018, 2:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31298

View Options

ksplash/ksplashqml/splashwindow.cpp

Loading...