Some project file manager plugins like KDevGenericManager do not have a list
of project file name filters. They need to be skipped when accumulating the
lists of file name filters instead of adding empty entries.
Details
Details
- Reviewers
mwolff - Group Reviewers
KDevelop - Commits
- R32:3a74e103e03a: Avoid emptry entries in project files filter list
Use "Open/Import Project..." action when running in environment with KDE_FULL_SESSION
being set and select the dropdown list of the filter selection.
No more empty entries after this patch.
Diff Detail
Diff Detail
- Repository
- R32 KDevelop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I think this may prevent KDevGenericManager from being selectable at all. Later in OpenProjectDialog::validateOpenUrl() we check for empty filters to add plugins that do not need a specific file:
Q_FOREACH ( const auto& plugin, m_projectFilters.keys() ) {
qCDebug(SHELL) << plugin << m_projectFilters.value(plugin);
if ( m_projectFilters.value(plugin).isEmpty() ) {
// that works in any case
auto meta = m_projectPlugins.value(plugin);
choices.append({plugin, meta.pluginId(), meta.iconName()});
}
}