Properly use kpackage_install_package
ClosedPublic

Authored by zzag on Apr 3 2018, 9:07 PM.

Details

Summary

NO_DEPRECATED_WARNING passed as the fifth arg to
kpackage_install_package disables a deprecation warning. Passing
anything else does nothing.

Diff Detail

Repository
R31 Breeze
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Apr 3 2018, 9:07 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 3 2018, 9:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
zzag requested review of this revision.Apr 3 2018, 9:07 PM

@davidedmundson in https://github.com/KDE/plasma-workspace/commit/450ef5884d9e93e6f0a2df48aae82f9ed239b394 you said:

Concept is fine, but currently we have severe CMake issues ...

I've tried kpackage_install_bundled_package and it works pretty fine. Or am I missing something? (CMake version: 3.10.3)

mart added a subscriber: mart.May 2 2018, 1:03 PM

fine tis version (with kpackage_install_package and not yet the bundled version)

zzag added a comment.May 30 2018, 10:32 AM

Ping.

Also, could someone please explain what's wrong with kpackage_install_bundled_package?

zzag retitled this revision from properly use kpackage_install_package to Properly use kpackage_install_package.May 30 2018, 10:33 AM
davidedmundson accepted this revision.Aug 28 2018, 10:38 AM
This revision is now accepted and ready to land.Aug 28 2018, 10:38 AM
This revision was automatically updated to reflect the committed changes.