Fix multirename shortcut
ClosedPublic

Authored by rade on Apr 3 2018, 12:15 PM.

Details

Summary

Rename was previously moved from F9 to F2. However multirename remained on shift+F9. This patch moves it too shift+F2.

Test Plan

No testing needed

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rade requested review of this revision.Apr 3 2018, 12:15 PM
rade created this revision.
asensi accepted this revision as: asensi.Apr 3 2018, 2:55 PM
asensi added a subscriber: asensi.

Thanks, Rade!

I also added a "tag" named "Krusader" and so:

In this differential, a "...added a project: Krusader." message was added.

This differential is seen now in:

This revision is now accepted and ready to land.Apr 3 2018, 2:55 PM
martinkostolny accepted this revision.Apr 3 2018, 9:40 PM
martinkostolny added a subscriber: martinkostolny.

Thanks, Rade, for the fix :).

rade added a comment.Apr 3 2018, 9:42 PM

Thanks, Rade, for the fix :).

Thanks for always being so friendly! :)

nmel accepted this revision.Apr 4 2018, 6:33 AM
nmel added a subscriber: nmel.

Thanks for improving consistency!

I propose we add CHANGED: ... to commit message, so it goes to the ChangeLog.

Rename was previously moved from F9 to F2.

Can someone point me to the story behind it? I'm curious why the new default was considered to be better.
I see that commit message has REVIEW: 124448 but how do I access it?

I propose we add CHANGED: ... to commit message, so it goes to the ChangeLog.

I agree.

I'm curious why the new default was considered to be better.

I think it was changed due to various GUI file managers (windows, linux) support F2 for renaming. I'm also accustomed to use F2 as rename.

I see that commit message has REVIEW: 124448 but how do I access it?

The review took place in the old reviewboard: https://git.reviewboard.kde.org/r/124448/

nmel added a comment.Apr 4 2018, 7:27 AM

Thanks Martin!

asensi added a comment.Apr 4 2018, 9:08 AM

Thanks for improving consistency!

I propose we add CHANGED: ... to commit message, so it goes to the ChangeLog.

Hi! In https://community.kde.org/Policies/Commit_Policy they wrote:

CHANGELOG: ['optional one line description']
The optional one line description will be used to fill automatically the release changelog. If it is not there the first line of the commit will be used. If it is fixing a bug, there's no need to mention the bug number if you are already using the BUG: keyword

though I haven't tried it.

rade added a comment.EditedApr 4 2018, 10:33 AM
In D11903#239525, @nmel wrote:

Rename was previously moved from F9 to F2.

Can someone point me to the story behind it? I'm curious why the new default was considered to be better.

In addition too what martinkostolny said about F2 being standard in other file managers it's worth noting that it is _not_ the OFM standard rename shortcut. According to what wikipedia purports to be the official OFM standards document shift+F6 should be rename and F2 should open the menu. From what I have been able to find (with the minimal amount of research I have done so far) some OFMs don't bother binding F2 but none I can find bind it to rename (at least not in screenshots).
As users can be expected to use this together with other OFMs on different platforms I feel that we should probably stick to the standard of having F2 be menu and shift+F6 be rename. The whole point of the OFM standard is to have it be the same regardless of specific program so you don't have to remember the specific shortcuts for all the different programs.
This might be worth discussing on the mailing list.
PS
After looking at the standard and mc I fell that ctrl+alt+T to open embedded terminal should probably be moved to Ctrl-O and that Ctrl+shift+O should open the terminal window instead of F9 ( note Ctrl+shft+O is not part of the standard.). I don't like having it on F9 partialy because it goes against the standard partially because it is too close to the close button. I hit F10 quite often when I mean too hit F9.

Rade, interesting thought about the OFM standard! I've created a topic in krusader-devel so we can discuss:
https://groups.google.com/forum/#!topic/krusader-devel/zu1dE3GUK0w

nmel added a comment.Apr 5 2018, 5:58 AM

Thanks for improving consistency!

I propose we add CHANGED: ... to commit message, so it goes to the ChangeLog.

Hi! In https://community.kde.org/Policies/Commit_Policy they wrote:

CHANGELOG: ['optional one line description']
The optional one line description will be used to fill automatically the release changelog. If it is not there the first line of the commit will be used. If it is fixing a bug, there's no need to mention the bug number if you are already using the BUG: keyword

though I haven't tried it.

Krusader uses slightly different keywords, check it out in our dev wiki. We can discuss moving to KDE policy keywords but until we release v2.7 we should stick to the current policy. CHANGED: needs to be used in this case. Thanks!

This revision was automatically updated to reflect the committed changes.