Isn't that translation breaking

RotationJobInternal::run

?

Why would you translate the image there?

Oh yes this may break it, I am thinking of adding another Boolean parameter to the RotationJob::rotationMatrix function with a default value of false to either translate or not
The function can be:
RotationJob::rotationMatrix( Rotation from, Rotation to, bool translate = false )

In D11901#239734, @ahmadosama wrote:

Oh yes this may break it, I am thinking of adding another Boolean parameter to the RotationJob::rotationMatrix function with a default value of false to either translate or not
The function can be:
RotationJob::rotationMatrix( Rotation from, Rotation to, bool translate = false )

I don't think that's a good idea, also the translations are a bit "random", why are they only 0 or 1?, i guess because you know the HighlightAreaRect are from 0 to 1, but that's knowledge that it's a bit "extra" to the rotationMatrix function.

Can you check if we simply should not be using RotationJob::rotationMatrix? the other objects in the loop above are transformed using a different matrix and those ones seem to work? Maybe you can use that one?

I tried rotating using ( const QTransform matrix = rotationMatrix() ) but it only works when rotating a page from its original orientation, this is why I modified the RotationJob::rotationMatrix in a way similar to Okular::buildRotationMatrix to allow rotating from different orientations.

In D11901#241751, @ahmadosama wrote:

I tried rotating using ( const QTransform matrix = rotationMatrix() ) but it only works when rotating a page from its original orientation, this is why I modified the RotationJob::rotationMatrix in a way similar to Okular::buildRotationMatrix to allow rotating from different orientations.

So you mean that the rects in m_page->m_rects are not being rotated correctly either?

As far as I know rotating m_page->m_rects should rotate annotations on the page, the annotations seem to work well when rotating them.

When rotating the highlights I tried to replace:
(*hlIt)->transform( RotationJob::rotationMatrix( oldRotation, m_rotation ) );
with
(*hlIt)->transform( matrix );

but highlights were rotated correctly only from the original orientation.

I am thinking of creating another function to get the rotation matrix for the highlights, or modify the Okular::buildRotationMatrix
as follows Okular::buildRotationMatrix(Rotation oldRotation = Rotation0, Rotation newRotation)

I am still going through the code to find a better way to solve this bug.

I will investigate more to find out why m_rects and m_highlights need different transformation matrices.