| ngraham |
| Dolphin |
We are asking the users whether they are sure they want to quit.
But the "Quit" button can be ambiguous (am I quitting dolphin or just
this dialog?). If we use a "Quit Dolphin" button instead, that clearly
shows what will happen after triggering the action.
Close dolphin while multiple tabs are open.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Sorry, I can't approve of this change. Button text should (almost) always use verbs instead of "Yes" or "No" because many users don't read the explanatory text, just the buttons. A Button that says "Quit" makes it clear what's about to happen if you didn't read the explanatory text; a button that says "Yes" does not.
For evidence of this phenomenon and more information on the subject, see:
As for possible confusion over what's being "quit", I'm not sure that's a problem. Windows are closed; apps are quit. Our own menu items reflect this distinction and I don't think many users are confused by what's going to happen when they click a Quit button. If you think it's really a problem, we should make the button say "Quit Dolphin" instead of just "Quit."
Right. How about "Close All Tabs"? But I'd also be ok with "Quit Dolphin".
As for possible confusion over what' being "quit", I'm not sure that's a problem. Windows are closed; apps are quit.
As a non-native speaker who runs dolphin in english, the distinction is not so clear...
I'd prefer "Quit Dolphin", since then it also teaches the user that "Quit" it something that applies to apps, if they're not already familiar with this concept.
