Fixing: https://.kde.org/show_bug.cgi?=282884
using QtFileInfo::baseName to strip file of its extension before adding the archive extension.
Details
Details
- Reviewers
elvisangelaccio rthomsen - Maniphest Tasks
- T1875: Do not create archives with double extension
- Commits
- R36:e206a274a418: Don't create archives with double extension
Diff Detail
Diff Detail
- Repository
- R36 Ark
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
kerfuffle/addtoarchive.cpp | ||
---|---|---|
242 | Better use fileInfo for this variable name | |
253 | What happens if I compress a file with name README-v1.4.2.txt ? Have a look at the function Archive::completeBaseName(), you should do the same thing here :) |
Comment Actions
Code looks good. Tested and seems to work properly. Great work :)
kerfuffle/addtoarchive.cpp | ||
---|---|---|
248 | Please start comments with capital letter, and end with period. Same below. |
kerfuffle/addtoarchive.cpp | ||
---|---|---|
243 | Please change the name of this variable to "parentDir", to make code more readable. |