Get rid of scripting
Needs ReviewPublic

Authored by malteveerman on Apr 1 2018, 3:20 PM.

Details

Reviewers
None
Group Reviewers
Amarok
Summary

Since Qt5Script is deprecated and virtually useless without bindings support I got rid of it.
I moved the lyrics functionality to LyricsManager but the rest I deleted without reimplementing it in C++.

Diff Detail

Repository
R181 Amarok
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
malteveerman requested review of this revision.Apr 1 2018, 3:20 PM
malteveerman created this revision.
markey added a subscriber: markey.Apr 4 2018, 6:42 PM

See, the problem with removing features like this is, there will be a huge outcry from users. That's guaranteed, even without knowing for sure how much the scripting feature is really used in the wild.

I was discussing about this with Heiko. Maybe QtScript could be replaced with QJSEngine, similar to how the following patch for another project attempts to do it?

https://phabricator.kde.org/D7033

See, the problem with removing features like this is, there will be a huge outcry from users. That's guaranteed, even without knowing for sure how much the scripting feature is really used in the wild.

I was discussing about this with Heiko. Maybe QtScript could be replaced with QJSEngine, similar to how the following patch for another project attempts to do it?

https://phabricator.kde.org/D7033

I see your point about removing features. But I've taken a look at the most popular scripts on opendesktop.org and they all rely on Qt bindings. Unless there is some way to restore bindings support this feature is broken and people will complain anyway.
About replacing QtScript with QJSEngine: I think it's quite possible to do so, but I have my doubts if the development and maintenance work is worth it given our limited manpower.
Anyway, I'll open a new revision just with the patch that implements the lyrics functionality in C++.